pika-git-forge-model-1

A new crate crates/pika-forge-model is created with minimal dependencies (serde and serde_json). It is added to the workspace members list in the root Cargo.toml and given a workspace-level path alias so downstream crates can reference it as pika-forge-model = { path = "../pika-forge-model" } or via workspace inheritance.

The crate intentionally has no runtime dependencies beyond serialization, keeping it lightweight for both server and CLI consumers.

The string_enum! macro is the core abstraction of the new crate. For each invocation it generates:

1. An enum with all named variants plus Unknown(String) for unrecognized wire values.
2. as_str(&self) -> &str returning the canonical wire representation.
3. From<&str> and From<String> conversions that map known strings to variants and everything else to Unknown.
4. Custom Serialize / Deserialize implementations that go through the string representation.
5. A Display implementation delegating to as_str().

This means the server can add new status values without breaking older CLI clients — they simply deserialize into Unknown("new_value") and round-trip cleanly.

Six enums are defined via the macro:

• BranchState — Open, Merged, Closed
• TutorialStatus — Pending, Ready, Failed
• ForgeCiStatus — 20+ variants covering every known CI status, with is_active() and is_success() helpers
• CiLaneStatus — lane-specific subset (Queued, Running, Success, Failed, Skipped, Lost, TimedOut, Cancelled) with its own is_active()
• CiLaneExecutionReason — with label() returning human-readable text and a Default impl yielding Queued
• CiLaneFailureKind — TestFailure, Timeout, Infrastructure with label()
• CiTargetHealthState — Healthy, Unhealthy

Having distinct ForgeCiStatus vs CiLaneStatus types prevents accidental mixing of run-level and lane-level statuses.

All response structs (BranchResolveResponse, BranchSummary, BranchDetailResponse, CiRun, CiLane, BranchLogsResponse, NightlyDetailResponse, LaneMutationResponse, RecoverRunResponse, WakeCiResponse, BranchActionResponse) are moved here with pub visibility and both Serialize + Deserialize.

Key changes compared to the old per-crate definitions:

• Status fields that were String are now their respective enum types.
• New optional fields are added with #[serde(default)]: status_tone, status_badge_class, is_failed, execution_reason_label, failure_kind_label, timing_summary, last_heartbeat_at, lease_expires_at, operator_hint.
• BranchLogsResponse gains generic type parameters for pikaci-specific payload types, defaulting to serde_json::Value so the CLI can deserialize without knowing server-internal types.

Unit tests verify unknown status round-tripping and default deserialization of execution_reason.

ph/Cargo.toml adds the pika-forge-model dependency. In api.rs, the large block of struct and enum definitions (lines 30–224 in the old file) is deleted and replaced with a single pub(crate) use pika_forge_model::{...} re-export.

In commands.rs, every raw string comparison is replaced with the typed method:

• branch.branch.ci_status == "success" → branch.branch.ci_status.is_success()
• matches!(status.as_str(), "queued" | "running") → status.is_active()
• lane.failure_kind changes from Copy enum to Option<CiLaneFailureKind> reference (.as_ref() added)
• CiTargetHealthState comparison now uses matches!(...as_ref(), Some(...))
• CiLaneExecutionReason comparison uses .as_str() on both sides since the type is no longer Copy

In tests.rs, test fixtures are updated to construct enum variants directly (BranchState::Open, ForgeCiStatus::Running, CiLaneStatus::Queued) and populate the new optional fields (status_tone, timing_summary, operator_hint, etc.).

pika-news/Cargo.toml adds the shared dependency. In web.rs:

1. Deleted structs: ForgeBranchResolveResponse, ForgeBranchSummaryResponse, ForgeBranchDetailResponse, ForgeBranchLogsResponse, and ForgeNightlyDetailResponse are removed (~60 lines). They are replaced by imports from pika_forge_model with type aliases where names differ.

2. Type alias for logs: ForgeBranchLogsResponse is defined as SharedForgeBranchLogsResponse<CiLane, RunRecord, RunLogsMetadata, PreparedOutputsRecord>, specializing the generic parameters with server-specific pikaci types.

3. New mapping functions: Four functions are added to convert internal DB/view records into the shared API types:

   • map_api_ci_run — wraps existing map_ci_run_view and converts to CiRun
   • map_api_ci_lane — wraps map_ci_lane_view for branch lanes
   • map_api_ci_lane_from_view — direct CiLaneView → CiLane conversion
   • map_api_nightly_lane — wraps map_nightly_lane_view for nightly lanes

4. Handler updates: All forge API handlers (merge_handler, close_handler, fail_branch_ci_lane_handler, requeue_branch_ci_lane_handler, recover_branch_ci_run_handler, fail_nightly_lane_handler, requeue_nightly_lane_handler, recover_nightly_run_handler, wake_ci_handler, api_forge_branch_resolve_handler, api_forge_branch_detail_handler, api_forge_branch_logs_handler, api_forge_nightly_detail_handler) are updated from Json(serde_json::json!({...})) to Json(TypedStruct { ... }). String fields like branch_state and ci_status are now constructed via BranchState::from(...) and ForgeCiStatus::from(...) respectively.

This ensures the server's JSON responses exactly match the struct shapes the CLI deserializes, catching any schema drift at compile time.