pika-git-mirror-store-1

The bulk of this branch is a deletion pass across branch_store.rs. Three struct definitions totalling ~42 lines are removed from the top of the file (lines 212–253 in the old file). Three impl Store methods spanning ~174 lines are cut from the middle (record_mirror_sync_run, get_mirror_status, list_recent_mirror_sync_runs). Two private free functions (map_mirror_sync_row and classify_mirror_failure_kind, ~62 lines) are removed from near the bottom. Finally, the classifies_mirror_failure_kinds_for_runtime_safety_cases test and its classify_mirror_failure_kind import are deleted from the mod tests block.

Nothing else in branch_store.rs is modified beyond these removals and adjusting the test-module import line:

// Before
use super::{classify_mirror_failure_kind, BranchUpsertInput, CI_LANE_LEASE_LOST};
// After
use super::{BranchUpsertInput, CI_LANE_LEASE_LOST};

A new file mirror_store.rs (313 lines) is created containing everything removed from branch_store.rs:

1. Imports — anyhow::Context, rusqlite::{params, OptionalExtension}, and crate::storage::Store.
2. Three structs — MirrorSyncRunRecord, MirrorStatusRecord, and MirrorSyncRunInput, copied verbatim.
3. impl Store block with the three public methods:
   • record_mirror_sync_run — records a new sync run row. One notable change: the repo-metadata lookup now calls self.ensure_forge_repo_metadata(...) before entering with_connection, rather than calling the module-private ensure_repo_metadata inside the connection closure. This decouples the metadata upsert from the insert transaction.
   • get_mirror_status — aggregates the latest attempt, last success/failure timestamps, and consecutive-failure streak for a given remote.
   • list_recent_mirror_sync_runs — returns the N most recent sync runs for a remote.
4. map_mirror_sync_row — maps a rusqlite::Row into MirrorSyncRunRecord, calling classify_mirror_failure_kind to populate failure_kind.
5. classify_mirror_failure_kind — pattern-matches error text into categories: obsolete, stale, busy, timeout, config, or transient.
6. #[cfg(test)] mod tests — the classifies_mirror_failure_kinds_for_runtime_safety_cases test verifying the classifier against four representative error strings.

// New standalone impl block in mirror_store.rs
impl Store {
    pub fn record_mirror_sync_run(&self, input: &MirrorSyncRunInput) -> anyhow::Result<i64> {
        let repo_id = self.ensure_forge_repo_metadata(
            &input.repo,
            &input.canonical_git_dir,
            &input.default_branch,
            "ci/forge-lanes.toml",
        )?;
        self.with_connection(|conn| { /* INSERT ... */ })
    }
    // ... get_mirror_status, list_recent_mirror_sync_runs
}

A single line mod mirror_store; is added to main.rs in alphabetical order between mod mirror and mod model. This is the only change needed to wire the new module into the crate's module tree.

In forge_runtime.rs, the import of MirrorStatusRecord switches from crate::branch_store to crate::mirror_store. The import is also repositioned alphabetically among the use statements.

mirror.rs is the primary consumer of all three mirror types. The single grouped import line is moved from crate::branch_store to crate::mirror_store, keeping MirrorStatusRecord, MirrorSyncRunInput, and MirrorSyncRunRecord in the same import.

In the web.rs test module, the combined import from branch_store is split: BranchUpsertInput stays with crate::branch_store, while MirrorStatusRecord and MirrorSyncRunRecord move to a new use crate::mirror_store line. This is the last consumer that needed updating.