Back to feed

sledtools/pika branch #22

codex/ts-ci-coverage

Add path-scoped pikachat TypeScript CI lane

Target branch: master

Merge Commit: 3da79e21fae01876cc4b464c1edbc4aefa382da6

branch: merged tutorial: ready ci: failed
Open CI Details

Continuous Integration

CI: failed

Compact status on the review page, with full logs on the CI page.

Open CI Details

Latest run #27 failed

9 passed 1 failed

head 601b1d42c42f8536dbd8d1bbfc4272d86039a4f5 · queued 2026-03-20 18:24:34 · 10 lane(s)

queued 7s · ran 3s

check-pika-rust · success check-pika-followup · success check-notifications · success check-agent-contracts · success check-rmp · success check-pikachat · success check-pikachat-typescript · success check-apple-host-sanity · failed check-pikachat-openclaw-e2e · success check-fixture · success

Summary

This branch introduces a dedicated, path-scoped TypeScript CI lane (pikachat_typescript) for the pikachat-claude and pikachat-openclaw TypeScript packages. Previously, TypeScript checks were either bundled into the broader Rust-oriented pikachat CI lane or invoked ad-hoc via npx. The new lane adds a standalone shell script (scripts/pikachat-typescript-ci.sh) that stages each package into a clean temporary directory, runs npm install, tsc --noEmit, and npm test. The lane is wired end-to-end: forge lane manifest registration with path globs, pikaci target and job model enums, a Nix-built VM guest wrapper, justfile integration, CI shim routing, documentation in ci-selectors.md, and comprehensive Rust and Python tests proving that a change to e.g. pikachat-claude/src/channel-runtime.ts selects only the new TypeScript lane and not the Rust lane.

Tutorial Steps

Register the new forge lane in the manifest

Intent: Declare a new `pikachat_typescript` branch lane in the forge lane manifest so the CI selector can match TypeScript-related path changes to a dedicated lane instead of falling through to the broader pikachat Rust lane.

Affected files: ci/forge-lanes.toml

Evidence 
@@ -201,6 +201,27 @@ paths = [
+[[branch.lanes]]
+id = "pikachat_typescript"
+title = "check-pikachat-typescript"
+staged_linux_target = "pre-merge-pikachat-typescript"
+paths = [
+  "ci/forge-lanes.toml",
+  ".github/workflows/pre-merge.yml",
+  "crates/pikaci/**",
+  "nix/ci/linux-rust.nix",
+  "scripts/forge-github-ci-shim.py",
+  "scripts/pikaci-staged-linux-remote.sh",
+  "scripts/pikachat-typescript-ci.sh",
+  "pikachat-claude/package.json",
+  "pikachat-claude/tsconfig.json",
+  "pikachat-claude/src/**",
+  "pikachat-openclaw/openclaw/extensions/pikachat-openclaw/package.json",
+  "pikachat-openclaw/openclaw/extensions/pikachat-openclaw/tsconfig.json",
+  "pikachat-openclaw/openclaw/extensions/pikachat-openclaw/index.ts",
+  "pikachat-openclaw/openclaw/extensions/pikachat-openclaw/src/**",
+]

A new [[branch.lanes]] entry is appended to ci/forge-lanes.toml with id = "pikachat_typescript" and staged_linux_target = "pre-merge-pikachat-typescript". The paths array is carefully scoped to only the TypeScript package surfaces (pikachat-claude/src/**, pikachat-openclaw/.../src/**, their package.json and tsconfig.json files) plus the CI plumbing files that govern the lane itself. This means a pure .ts file change will select only this lane and not the heavier Rust-oriented pikachat lane.

Extend the pikaci model with TypeScript target and lane enums

Intent: Add the new `PreMergePikachatTypescript` target variant and `PikachatTypescript` lane variant to the pikaci Rust model so the CI orchestrator can resolve, configure, and dispatch jobs for the TypeScript lane.

Affected files: crates/pikaci/src/model.rs

Evidence 
@@ -155,6 +155,7 @@ pub enum StagedLinuxRustTarget {
+    PreMergePikachatTypescript,
@@ -197,6 +198,7 @@ pub enum StagedLinuxRustLane {
+    PikachatTypescript,
@@ -230,6 +232,7 @@ impl StagedLinuxRustLane {
+            Self::PikachatTypescript => "pikachat_typescript",
@@ -271,6 +274,7 @@ impl StagedLinuxRustLane {
+            Self::PikachatTypescript => StagedLinuxRustTarget::PreMergePikachatTypescript,
@@ -364,6 +368,9 @@ impl StagedLinuxRustLane {
+            Self::PikachatTypescript => {
+                "/staged/linux-rust/workspace-build/bin/run-pikachat-typescript"
+            }
@@ -497,6 +506,18 @@ impl StagedLinuxRustTarget {
+            Self::PreMergePikachatTypescript => StagedLinuxRustTargetConfig {
+                target_id: "pre-merge-pikachat-typescript",
+                ...
+                shadow_recipe: "",
+            },

The StagedLinuxRustTarget enum gains PreMergePikachatTypescript and StagedLinuxRustLane gains PikachatTypescript. All the required trait-like method arms are filled in:

  • selector_key() returns "pikachat_typescript".
  • target() maps the lane back to PreMergePikachatTypescript.
  • execute_wrapper_command() returns "/staged/linux-rust/workspace-build/bin/run-pikachat-typescript".
  • from_target_id("pre-merge-pikachat-typescript") parses correctly.
  • config() reuses the existing pikachatWorkspaceDeps / pikachatWorkspaceBuild Nix outputs since the TypeScript lane shares the same workspace derivation. Notably shadow_recipe is set to the empty string — there is no shadow justfile recipe for this lane.

Extensive new unit tests (pikachat_lane_uses_pikachat_workspace_outputs, selector_key, target config round-trip assertions, and the exhaustive target list test) validate every new arm.

Wire the pikaci target spec and job definition

Intent: Register the `pre-merge-pikachat-typescript` target name in the pikaci dispatcher so that `pikaci run pre-merge-pikachat-typescript` resolves to a single job that runs inside a staged Linux microVM.

Affected files: crates/pikaci/src/main.rs

Evidence 
@@ -586,6 +586,26 @@ fn target_spec(name: &str) -> anyhow::Result<TargetSpec> {
+        "pre-merge-pikachat-typescript" => Ok(staged_linux_target_spec(
+            StagedLinuxRustTarget::PreMergePikachatTypescript,
+            &[
+                ...path globs...
+            ],
+            pikachat_typescript_jobs(),
+        )),
@@ -1417,6 +1437,17 @@ fn pikachat_openclaw_e2e_jobs() -> Vec<JobSpec> {
+fn pikachat_typescript_jobs() -> Vec<JobSpec> {
+    vec![JobSpec {
+        id: "pikachat-typescript",
+        description: "Run the Claude and OpenClaw TypeScript typecheck and unit tests in a remote Linux microVM",
+        timeout_secs: 1800,
+        writable_workspace: false,
+        guest_command: GuestCommand::ShellCommand { command: "ignored" },
+        staged_linux_rust_lane: Some(StagedLinuxRustLane::PikachatTypescript),
+    }]
@@ -2040,6 +2071,19 @@ mod tests {
+    #[test]
+    fn pre_merge_pikachat_typescript_target_uses_staged_linux_runner() {

In target_spec(), a new match arm maps "pre-merge-pikachat-typescript" to a staged_linux_target_spec with the same set of path globs used in the forge lane manifest. The pikachat_typescript_jobs() helper returns a single JobSpec with:

  • 30-minute timeout (1800 seconds).
  • writable_workspace: false — the TypeScript CI script stages into /tmp, so it does not need a writable snapshot.
  • guest_command is "ignored" because the staged Linux runner uses execute_wrapper_command() from the lane enum instead.

A new test pre_merge_pikachat_typescript_target_uses_staged_linux_runner asserts the job count, lane mapping, and runner kind.

Create the TypeScript CI shell script

Intent: Provide a standalone, scope-aware shell script that installs, typechecks, and unit-tests the pikachat TypeScript packages in an isolated staging directory.

Affected files: scripts/pikachat-typescript-ci.sh

Evidence 
@@ -0,0 +1,113 @@
+#!/usr/bin/env bash
+set -euo pipefail
+
+usage() {
+  cat <<'EOF'
+Usage: ./scripts/pikachat-typescript-ci.sh [--scope all|claude|openclaw]
+...

This is the core new artifact. scripts/pikachat-typescript-ci.sh is a self-contained Bash script with the following design:

  1. Scope flag (--scope all|claude|openclaw) — defaults to all. Allows callers to run only one package, which the justfile leverages for the OpenClaw-only deterministic recipe.
  2. Staging — stage_package_dir() uses tar --exclude='./node_modules' --exclude='./package-lock.json' to copy the source package into a fresh mktemp directory. This isolates CI from any local node_modules state.
  3. Cleanup trap — a trap cleanup EXIT removes all staging directories on exit.
  4. npm binary override — PIKACHAT_TYPESCRIPT_CI_NPM_BIN allows the Nix VM wrapper to inject a Nix-store npm path, falling back to the ambient npm.
  5. Three-phase per-package — run_package() runs npm install --include=dev, npm run typecheck (which invokes tsc --noEmit), and npm test.

The script handles both pikachat-claude and the deeply nested pikachat-openclaw/openclaw/extensions/pikachat-openclaw package.

Add the Nix VM guest wrapper for the TypeScript lane

Intent: Create a `run-pikachat-typescript` wrapper script inside the Nix-built workspace so the staged Linux microVM can execute the TypeScript CI lane with the correct Node.js binary.

Affected files: nix/ci/linux-rust.nix

Evidence 
@@ -1521,6 +1521,16 @@ CFG
+          cat >"$out/bin/run-pikachat-typescript" <<'EOF'
+          #!${pkgs.bash}/bin/bash
+          set -euo pipefail
+
+          if [ -f /workspace/snapshot/Cargo.toml ]; then
+            cd /workspace/snapshot
+          fi
+          export PIKACHAT_TYPESCRIPT_CI_NPM_BIN="${pkgs.nodejs_22}/bin/npm"
+          exec ./scripts/pikachat-typescript-ci.sh
+          EOF
@@ -1610,6 +1620,7 @@ CFG
+            "$out/bin/run-pikachat-typescript" \

The Nix derivation for pikachatWorkspaceBuild now emits a run-pikachat-typescript wrapper alongside the existing Rust integration test wrappers. Key details:

  • It cds into /workspace/snapshot if a Cargo.toml is present (the standard workspace snapshot convention).
  • It exports PIKACHAT_TYPESCRIPT_CI_NPM_BIN pointing to the Nix-store nodejs_22 npm binary, ensuring a reproducible Node version inside the VM.
  • It execs into ./scripts/pikachat-typescript-ci.sh with no scope flag, so both packages are tested.
  • The wrapper path is added to the chmod +x list so it is executable in the output.

Update the justfile to delegate to the new script

Intent: Replace the inline `npx --yes tsx --test ...` invocation in the `openclaw-pikachat-deterministic` recipe with a call to the new CI script, keeping one canonical entry point for TypeScript testing.

Affected files: just/checks.just

Evidence 
@@ -280,7 +280,7 @@ openclaw-pikachat-deterministic:
-    npx --yes tsx --test pikachat-openclaw/openclaw/extensions/pikachat-openclaw/src/channel-behavior.test.ts
+    ./scripts/pikachat-typescript-ci.sh --scope openclaw

The openclaw-pikachat-deterministic justfile recipe previously ran npx --yes tsx --test directly against the OpenClaw test file. This is replaced with ./scripts/pikachat-typescript-ci.sh --scope openclaw, which not only runs the test but also performs a fresh npm install and tsc --noEmit typecheck in a staged directory. The --scope openclaw flag limits execution to only the OpenClaw package, keeping the recipe focused.

Add a test script to the openclaw package.json

Intent: Give the openclaw package a proper `npm test` script so the CI shell script can invoke `npm test` uniformly across both packages.

Affected files: pikachat-openclaw/openclaw/extensions/pikachat-openclaw/package.json

Evidence 
@@ -7,13 +7,15 @@
-    "typecheck": "tsc --noEmit"
+    "typecheck": "tsc --noEmit",
+    "test": "node --import tsx --test src/**/*.test.ts"
+    "tsx": "^4.19.3",

Two changes to the openclaw extension package.json:

  1. A "test" script is added: node --import tsx --test src/**/*.test.ts. This uses the Node.js built-in test runner with tsx as a loader, replacing the previous npx --yes tsx --test approach.
  2. tsx is added as an explicit devDependency (^4.19.3) instead of relying on npx to fetch it on-the-fly. This makes the dependency explicit and reproducible.

Add a comment to the channel-runtime TypeScript source

Intent: Annotate the pruned baseline persistence step in `PikachatClaudeChannel` to clarify its purpose relative to the daemon lifecycle.

Affected files: pikachat-claude/src/channel-runtime.ts

Evidence 
@@ -111,6 +111,7 @@ export class PikachatClaudeChannel {
+    // Persist a pruned baseline before the daemon starts mutating access state.

A single clarifying comment is added before the pruneExpiredPairings / saveAccessState call in the channel boot path. This makes it clear that the pruned state is written as a baseline before the daemon begins mutating access state, which is relevant context for understanding the access-file lifecycle.

Add the Rust selector test for TypeScript path routing

Intent: Prove that a change to a TypeScript source file selects only the new `pikachat_typescript` lane and does not trigger the Rust-oriented `pikachat` lane.

Affected files: crates/pika-news/src/ci_manifest.rs

Evidence 
@@ -200,6 +200,20 @@ mod tests {
+    #[test]
+    fn typescript_plugin_branch_selects_only_typescript_lane() {
+        let manifest =
+            parse_manifest(include_str!("../../../ci/forge-lanes.toml")).expect("manifest");
+        let changed = vec!["pikachat-claude/src/channel-runtime.ts".to_string()];
+        let selected = select_branch_lanes(&manifest, &changed).expect("select lanes");
+        let ids = selected.into_iter().map(|lane| lane.id).collect::<Vec<_>>();
+
+        assert!(ids.contains(&"pikachat_typescript".to_string()));
+        assert!(!ids.contains(&"pikachat".to_string()));
+        assert!(!ids.contains(&"pika_rust".to_string()));
+        assert!(!ids.contains(&"pika_followup".to_string()));
+    }
@@ -262,6 +276,7 @@ command = ["./nightly.sh"]
+            ("pikachat_typescript", "pre-merge-pikachat-typescript"),

Two test additions in ci_manifest.rs:

  1. typescript_plugin_branch_selects_only_typescript_lane — parses the real forge-lanes.toml, simulates a single changed file pikachat-claude/src/channel-runtime.ts, and asserts that pikachat_typescript is selected while pikachat, pika_rust, and pika_followup are not. This is the critical routing correctness test.
  2. The exhaustive canonical_manifest_change_selects_branch_lanes test gains the ("pikachat_typescript", "pre-merge-pikachat-typescript") pair, ensuring the lane's target mapping is verified against the real manifest.

Add the Python end-to-end CI shim test for TypeScript routing

Intent: Verify that the forge GitHub CI shim correctly routes a TypeScript file change through the full git-based selection pipeline to the dedicated lane.

Affected files: scripts/test_forge_github_ci_shim.py

Evidence 
@@ -271,6 +271,95 @@ command = ["python3", "-c", "print('nightly')"]
+    def test_branch_selection_routes_typescript_changes_to_dedicated_lane(self) -> None:
+        with tempfile.TemporaryDirectory() as tmp:
+            repo = Path(tmp)
+            ...
+            payload = json.loads(completed.stdout)
+            self.assertEqual(
+                [lane["id"] for lane in payload["include"]],
+                ["pikachat_typescript"],
+            )
@@ -721,6 +810,7 @@ command = ["python3", "-c", "print('nightly')"]
+                "pikachat_typescript",
@@ -758,6 +848,18 @@ command = ["python3", "-c", "print('nightly')"]
+        self.assertEqual(
+            commands["pikachat_typescript"],
+            [
+                "./scripts/pikaci-staged-linux-remote.sh",
+                "run",
+                "pre-merge-pikachat-typescript",
+            ],
+        )

The Python test suite for the forge GitHub CI shim gets a new test test_branch_selection_routes_typescript_changes_to_dedicated_lane. It:

  1. Creates a temporary git repo with a minimal forge-lanes.toml containing both pikachat_typescript and pikachat lanes.
  2. Commits a base state, then modifies only pikachat-claude/src/channel-runtime.ts.
  3. Runs the select --mode branch command and asserts the output JSON includes only pikachat_typescript.

Additionally, the exhaustive lane ordering test and the command/group mapping tests are extended to include the new pikachat_typescript lane with its expected command ["./scripts/pikaci-staged-linux-remote.sh", "run", "pre-merge-pikachat-typescript"] and group "staged-linux:pre-merge-pikachat-typescript".

Update documentation and help text

Intent: Record the new lane's contract in the CI selectors documentation and update the staged runner help text.

Affected files: docs/testing/ci-selectors.md, scripts/pikaci-staged-linux-remote.sh

Evidence 
@@ -27,6 +27,7 @@ This document defines the selector-first contract and current policy ownership f
+| `check-pikachat-typescript` | `./scripts/pikachat-typescript-ci.sh` over the checked-in `pikachat-claude` and `pikachat-openclaw` TypeScript package surfaces. This is a path-scoped pre-merge lane: it should trigger only for those TypeScript/plugin package paths and the lane plumbing that governs them. |
@@ -13,6 +13,7 @@ Targets:
+  pre-merge-pikachat-typescript

The ci-selectors.md documentation table gains a row for check-pikachat-typescript with its canonical contract description — it runs the TypeScript CI script and is path-scoped to only trigger for TypeScript package paths.

The pikaci-staged-linux-remote.sh help text's target list is updated to include pre-merge-pikachat-typescript so operators can discover it.

Diff