remove-ci-target-health

The pika-forge-model crate is the shared API contract between the server (pika-git) and the CLI (ph). Three changes are made here:

1. Execution reason variants removed — TargetUnhealthy and BlockedByTargetHealth are deleted from the CiLaneExecutionReason string enum, along with their label() mapping. The CiLaneExecutionReason enum in the forge model mirrors the one in ci_state.rs; both must stay in sync.

2. CiTargetHealthState enum removed entirely — The string_enum! block that defined Healthy / Unhealthy is deleted. No replacement is needed because health tracking no longer exists.

3. CiLane struct fields removed — target_health_state: Option<CiTargetHealthState> and target_health_summary: Option<String> are dropped from the serializable CiLane struct. Both fields had #[serde(default)] so older clients that still include them in JSON payloads will simply ignore the unknown keys (standard serde behavior with deny_unknown_fields not set).

ci_state.rs is the internal domain module for CI lane enums and helper functions. The following are removed:

• Constants CI_TARGET_HEALTH_INFRA_FAILURE_THRESHOLD (2) and CI_TARGET_HEALTH_COOLOFF_MINUTES (15) — these governed when a target flipped to unhealthy and how long the cooloff lasted.
• TargetUnhealthy variant from CiLaneExecutionReason plus its as_str(), label(), and FromStr arms.
• counts_toward_target_health() on CiLaneFailureKind — used to decide whether a failure should increment the consecutive counter.
• CiTargetHealthState enum (Healthy/Unhealthy) with Display, FromStr, and as_str() implementations.
• CiTargetHealthSnapshot struct and its effective_state(), is_currently_unhealthy(), and cooloff_active_until() methods.
• next_target_cooloff_until() and parse_ci_timestamp() helper functions.
• All associated unit tests (target_health_snapshot_only_blocks_while_cooloff_is_active, next_cooloff_until_is_in_the_future).

The chrono import is trimmed down since DateTime, Duration, and Utc are no longer needed in this module.

The ci_store.rs module contains the bulk of the scheduling and state-mutation logic. This is the largest set of deletions in the branch.

Scheduler claim paths

Both claim_pending_branch_ci_lane_runs() and claim_pending_nightly_ci_lane_runs() previously:

1. Called current_unhealthy_target_ids() to build a HashSet<String> of blocked targets.
2. For each candidate lane, looked up ci_target_key and skipped the lane if the target was in the unhealthy set.

Both checks are removed. The only remaining skip condition is the concurrency-group gate.

Lane finish paths

finish_branch_ci_lane_run() and finish_nightly_ci_lane_run() previously fetched ci_target_key alongside the run ID and called update_target_health_after_lane_finish(). Now they only fetch the run ID (SELECT branch_ci_run_id FROM ... / SELECT nightly_run_id FROM ...).

Deleted helper functions

• load_ci_target_health_snapshots() — batch-loaded health rows by target ID into a HashMap.
• hydrate_lane_target_health() / hydrate_nightly_lane_target_health() — post-load decoration of lane records with their target's health snapshot.
• current_unhealthy_target_ids() — queried ci_target_health table and filtered to currently-unhealthy targets.
• update_target_health_after_lane_finish() — the 120+ line function that incremented failure counters, flipped state to unhealthy, set cooloff timestamps, or reset on success.
• parse_target_health_state() — SQLite row parser for the health state enum.

Record structs

The target_health: Option<CiTargetHealthSnapshot> field is removed from both BranchCiLaneRecord and NightlyLaneRecord.

Execution reason refresh

refresh_queued_lane_reasons_for_table() no longer receives or checks unhealthy_targets. The TargetUnhealthy reason assignment branch is removed, simplifying the function to only handle concurrency-group blocking and capacity-waiting logic.

A new migration file 0026_drop_ci_target_health.sql ensures a clean transition for existing databases:

1. Rewrite stale execution reasons — Any branch_ci_run_lanes or nightly_run_lanes rows that still have execution_reason = 'target_unhealthy' are updated to 'queued'. This unblocks lanes that were parked due to the now-removed health gate, allowing them to be picked up by the next scheduler cycle.

2. Drop the table — DROP TABLE IF EXISTS ci_target_health removes the health-tracking table entirely. IF EXISTS is used for idempotency.

In storage.rs:

• The migration is registered as version 26 in the migrations() vector.
• The ci_queue_state_schema_present() guard function no longer checks for ci_target_health table existence — the schema is considered complete without it.
• The existing storage test that verified ci_target_health exists is flipped to assert !table_exists(conn, "ci_target_health").
• A new test drop_target_health_migration_rewrites_legacy_unhealthy_rows sets up a database at migration 25, inserts rows with target_unhealthy execution reasons and a ci_target_health entry, then opens a Store (which applies migration 26) and verifies the rows were rewritten to queued and the table was dropped.

The web layer spans several files:

web.rs (view structs and helpers)

• CiLaneView and NightlyLaneView both lose target_health_state: Option<String> and target_health_summary: Option<String>.
• ci_status_tone() no longer maps "target_unhealthy" or "blocked_by_target_health" to the "warning" tone.
• The import of CiTargetHealthSnapshot, CiTargetHealthState, and ForgeApiTargetHealthState is removed.

web/api.rs (API response mapping)

• map_api_ci_lane_from_view() and map_api_nightly_lane() both drop the target_health_state and target_health_summary field mappings when constructing the CiLane API response.

web/views.rs (record → view conversion)

The view-building functions that populated target_health_state and target_health_summary from the store records are simplified to omit those fields entirely.

Templates

branch_ci_live.html and nightly_live.html templates have their target-health-related conditional rendering blocks removed.

The ph CLI crate renders branch status to the terminal and computes a stable snapshot string used by branch wait to detect state changes.

api.rs

The re-export of CiTargetHealthState is removed from the import block.

commands.rs

• render_lane_status_line() — The block that appended " · <target_health_summary>" or " · target unhealthy" is deleted. Lane status lines now end after the failure kind (if present) and the target/run ID suffix.
• render_lane_snapshot_fragment() — The format string drops from 5 colon-separated fields to 4, removing the target_health_state segment. This means existing branch wait invocations will see a snapshot change on upgrade, which is the correct behavior since the health dimension no longer exists.

tests.rs

• The test is renamed from branch_status_renders_blocked_unhealthy_and_failure_details to branch_status_renders_waiting_and_failure_details.
• The entire CiLane entry for the apple-sanity lane (which was the unhealthy-target test case) is removed, and lane_count is reduced from 3 to 2.
• All target_health_state and target_health_summary fields are removed from the remaining lane constructors.
• Assertions for "apple-sanity queued · target unhealthy", "target apple-host unhealthy", and "target_unhealthy" in the snapshot are deleted.

branch_store.rs tests

• target_health_row() helper deleted — This helper queried the ci_target_health table directly for assertions; it is no longer needed.
• Test renamed — queue_reasons_and_unhealthy_targets_do_not_block_unrelated_claims becomes queue_reasons_do_not_block_unrelated_claims. The unhealthy_branch setup, the ci_target_health INSERT, and all assertions about TargetUnhealthy execution reasons and target_health snapshots are removed. The test now only verifies concurrency-group blocking and capacity-waiting behavior.
• target_health_tracks_infra_failures_and_resets_after_success deleted entirely — This was a ~100 line integration test that exercised the full health lifecycle: two consecutive infra failures triggering unhealthy state, cooloff blocking claims, cooloff expiry allowing retry, and success resetting the counter. With the feature removed, the entire test is unnecessary.

Web test suites

• web/tests/api.rs, web/tests/render.rs, and web/tests/unit.rs all have target_health_state and target_health_summary fields removed from test fixture construction, keeping the test data aligned with the updated structs.