pika-delete-acp-pi

The acp.rs module (~800 lines) is deleted in its entirety. This module contained:

• AcpBackendConfig — configuration struct holding the shell command and working directory for an external ACP agent.
• AcpJsonRpcClient — an async JSON-RPC 2.0 client that communicated with the ACP backend over stdin/stdout, handling requests, responses, and session/update streaming notifications.
• AcpSessionManager — conversation-to-session mapping layer that created ACP sessions on demand via session/new and routed prompts through session/prompt.
• AcpBackendManager — a higher-level queue-based manager that serialized prompts per conversation and delivered completions through an unbounded channel.
• default_acp_cwd() helper.
• Comprehensive integration tests using a fake Python ACP backend script.

In lib.rs, the pub mod acp; declaration is removed and the crate-level doc comment is updated to state that no secondary ACP backend bridge is hosted anymore.

Several intertwined pieces are removed from daemon.rs:

1. Import of ACP types — The use crate::acp::{AcpBackendConfig, AcpBackendManager, AcpTurnCompletion} import is deleted.

2. Helper functions — should_prompt_acp_reply() (which gated ACP prompts on classification, sender identity, and non-empty content) and build_acp_prompt() (which formatted the Nostr group context into an ACP prompt string) are removed.

3. daemon_main signature — The acp_backend: Option<AcpBackendConfig> parameter is removed. Inside the function, the block that conditionally spawned AcpBackendManager::spawn(config) and stored the completion receiver is deleted.

4. Select arm for ACP completions — The acp_completion = async { ... } arm in the main tokio::select! loop, which processed AcpTurnCompletion results (publishing reply messages on success, logging warnings on failure), is removed entirely.

5. Prompt enqueue on incoming messages — After processing an incoming chat message, the code that checked should_prompt_acp_reply, called build_acp_prompt, and enqueued via acp.enqueue_prompt() is deleted. Variables like acp_nostr_group_id, acp_sender_hex, and acp_content that were only used for this purpose are also removed.

6. Variable rename — The classification binding from the message interpretation match is prefixed with _ since it is no longer consumed by the ACP prompt logic.

7. Tests — acp_prompt_mapping_keeps_group_and_sender_context and acp_prompt_trigger_skips_self_and_empty_messages are deleted.

Three locations in main.rs are modified:

1. Command::Daemon variant — The acp_exec: Option<String> and acp_cwd: Option<PathBuf> fields (with their doc comments) are removed from the Daemon variant of the CLI enum.

2. Match arm — The destructuring of acp_exec and acp_cwd in the main match block, and their forwarding to cmd_daemon(), are removed.

3. cmd_daemon function — The acp_exec and acp_cwd parameters are removed from the signature. The body no longer constructs an AcpBackendConfig or passes acp_backend to daemon_main().

4. Test — daemon_command_parses_acp_backend_flags is deleted since the flags no longer exist.

The entire cli/src/agent/harness.rs file (~109 lines) is deleted. It contained:

• AgentHarnessSession trait — defining prompt(), steer(), follow_up(), abort(), and decode_event() methods.
• AcpMarmotSession — a concrete implementation wrapping MarmotSessionBuilder for the ACP protocol.
• new_harness_session() factory function.
• Three unit tests validating envelope round-tripping and idempotency key uniqueness.

The mod.rs for the agent module is updated to remove pub mod harness;.

In forge_manifest.rs:

1. A compile-time constant FORGE_MANIFEST_TOML is introduced using include_str!("../../../ci/forge-lanes.toml"), which embeds the manifest file contents directly into the binary.

2. load_branch_lane_paths() now calls toml::from_str(FORGE_MANIFEST_TOML) directly instead of std::fs::read_to_string(manifest_path()). The error context message is updated from "parse forge lane manifest" to "parse embedded forge lane manifest".

3. The manifest_path() helper function and the use std::path::Path import are removed since they are no longer needed.

This change makes the pikaci binary self-contained with respect to forge lane configuration — it no longer needs the source tree present at runtime.

A single line is added to the fileset unions list in the Nix mkPikaciSrc (or equivalent Cargo source derivation):

fileset = lib.fileset.unions [
  ./Cargo.toml
  ./Cargo.lock
  ./ci          # <-- added
  ./flake.nix
  ...
];

Without this addition, the Nix build sandbox would not contain ci/forge-lanes.toml, causing the include_str! macro in forge_manifest.rs to fail at compile time.

The Nix flake previously defined piAgentPkg, a buildNpmPackage derivation that pinned @mariozechner/pi-coding-agent at version 0.54.2 and exposed it as a pi binary. This is removed:

1. flake.nix — The entire piAgentPkg definition (~25 lines) is deleted, along with its entry in packages."x86_64-linux" (pi-agent-runtime = piAgentPkg;).

2. nix/pi-agent/package-lock.json — The 3,826-line npm lockfile is deleted.

3. nix/pi-agent/package.json — The package manifest is deleted.

This removes the pi coding agent runtime from the project's Nix outputs entirely.

In build_managed_guest_autostart, the environment variable passthrough loop previously forwarded ANTHROPIC_API_KEY, OPENAI_API_KEY, and PI_MODEL into the guest VM. PI_MODEL is removed from the list since the pi agent that consumed this variable is no longer part of the system. The remaining two API key variables continue to be forwarded.