pika-cloud-artifact-boundary

The runtime_artifacts field on GuestStartupArtifacts is renamed to lifecycle_artifacts. This field holds a RuntimeArtifactPaths value containing status_path, events_path, and result_path — all of which describe the guest's lifecycle state machine. The rename clarifies that these paths are specifically about lifecycle tracking, distinguishing them from the newly introduced service artifacts.

Because #[serde(flatten)] is used, the serialized JSON representation is unchanged; only the Rust field name changes. The validation call in GuestStartupArtifacts::validate_canonical_paths is updated accordingly:

self.lifecycle_artifacts
    .validate_canonical_paths("artifacts")?;

A new ManagedGuestServiceArtifacts struct is introduced to hold paths that belong to the managed guest service process rather than to the guest lifecycle state machine:

pub struct ManagedGuestServiceArtifacts {
    #[serde(rename = "log_path")]
    pub service_log_path: String,
    pub pid_path: String,
}

Key design decisions:

• #[serde(flatten)] on the parent field preserves wire-format compatibility — log_path and pid_path still appear at the top level of the serialized JSON.
• #[serde(rename = "log_path")] keeps the JSON key as log_path while giving the Rust field the more descriptive name service_log_path, avoiding ambiguity with other log paths in the system.
• The struct is added to GuestStartupArtifacts as service_artifacts, replacing the two previously inlined fields (log_path and pid_path).

ManagedGuestServiceArtifacts receives its own Default impl sourcing values from the existing constants GUEST_LOG_PATH and GUEST_PID_PATH, and a validate_canonical_paths method that mirrors the pattern already established by RuntimeArtifactPaths.

The validation iterates over each field, comparing the current value against the canonical default:

pub fn validate_canonical_paths(&self, field_prefix: &str) -> Result<(), String> {
    let canonical = Self::default();
    for (field, actual, expected) in [
        ("log_path", self.service_log_path.as_str(), canonical.service_log_path.as_str()),
        ("pid_path", self.pid_path.as_str(), canonical.pid_path.as_str()),
    ] {
        if actual != expected {
            return Err(format!(
                "{field_prefix}.{field} must use canonical path {expected:?}, got {actual:?}"
            ));
        }
    }
    Ok(())
}

The parent GuestStartupArtifacts::validate_canonical_paths method is simplified: the log_path and pid_path checks are removed from its inline loop and are now delegated to self.service_artifacts.validate_canonical_paths("artifacts").

The Default impl for GuestStartupArtifacts now delegates to the two sub-struct defaults:

Self {
    startup_plan_path: GUEST_STARTUP_PLAN_PATH.to_string(),
    identity_seed_path: GUEST_AUTOSTART_IDENTITY_PATH.to_string(),
    lifecycle_artifacts: RuntimeArtifactPaths::default(),
    service_artifacts: ManagedGuestServiceArtifacts::default(),
}

The validate_canonical_paths method loses the six-line inline check for log_path and pid_path, and instead chains two delegated validation calls:

self.lifecycle_artifacts.validate_canonical_paths("artifacts")?;
self.service_artifacts.validate_canonical_paths("artifacts")?;

This keeps the parent struct thin and ensures each sub-struct owns its own invariants.

All test assertions are mechanically updated to use the new field paths:

• In pika-cloud/src/lib.rs, the default-artifacts test now reads lifecycle_artifacts.status_path, service_artifacts.service_log_path, etc.
• A struct literal in the validation-error test switches from runtime_artifacts to lifecycle_artifacts.
• In pika-server/src/managed_openclaw_guest.rs, the guest_startup_plan_uses_shared_lifecycle_artifacts test updates all three assertions from runtime_artifacts to lifecycle_artifacts.

No new tests are added — the existing coverage already exercises the default values and canonical-path validation, and the refactoring preserves those contracts.